ECHOES-1032 Align icons in sidebar collapsed mode #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
david-cho-lerat-sonarsource
requested review from
gregaubert and
jeremy-davis-sonarsource
gregaubert
requested changes
Jan 6, 2026
src/components/layout/sidebar-navigation/SidebarNavigationAccordionItem.tsx
Show resolved
Hide resolved
src/components/layout/sidebar-navigation/SidebarNavigationGroup.tsx
Outdated
Show resolved
Hide resolved
david-cho-lerat-sonarsource
force-pushed
the
david/ECHOES-1032-align-icons-in-collapsed-mode
branch
2 times, most recently
from
e976e01 to
0dc6bf9
Compare
gregaubert
reviewed
Jan 6, 2026
src/components/layout/sidebar-navigation/SidebarNavigationAccordionItem.tsx
Outdated
Show resolved
Hide resolved
src/components/layout/sidebar-navigation/SidebarNavigationAccordionItem.tsx
Show resolved
Hide resolved
src/components/layout/sidebar-navigation/SidebarNavigationGroup.tsx
Outdated
Show resolved
Hide resolved
david-cho-lerat-sonarsource
force-pushed
the
david/ECHOES-1032-align-icons-in-collapsed-mode
branch
from
0dc6bf9 to
0f7e308
Compare
gregaubert
force-pushed
the
david/ECHOES-1032-align-icons-in-collapsed-mode
branch
from
0f7e308 to
1a75ab5
Compare
gregaubert
force-pushed
the
david/ECHOES-1032-align-icons-in-collapsed-mode
branch
from
1a75ab5 to
fe1f3fd
Compare
Member
|
@jeremy-davis-sonarsource @david-cho-lerat-sonarsource @amelia-adam-sonarsource Update done with the new selected state for the accordion, can you guys review it ? |
|
jeremy-davis-sonarsource
approved these changes
Jan 9, 2026
Contributor
jeremy-davis-sonarsource
left a comment
jeremy-davis-sonarsource
left a comment
There was a problem hiding this comment.
Looks great!
gregaubert
approved these changes
Jan 9, 2026
gregaubert
added a commit
that referenced
this pull request
Jan 9, 2026
Co-authored-by: Grégoire Aubert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.